Skip to content

ProductFormFeature and ProductIdentifier fixes

Chris Ribal requested to merge github/fork/codana-agency/onix_parser_fixes into master

Created by: WardVandevoort

Hi,

We started using this package and ran into some issues, so we decided to make a fork and fix them. Here are the changes.

ProductIdentifier: We noticed that there was no clean way of getting the ProductIDType, because there was no getter function for this property. So we added one.

ProductFormFeature: We ran into an issue where we would get InvalidCodeListCodeExceptions because ProductFormFeatureValue only expects CodeList98 values, when it should also be able to handle CodeList220 values. We added an extra typing and this fixed the issue.

I saw @conatus made the same change in his pull request, so it seems to be a common problem.

Merge request reports